refactor: replace sort.Slice with slices.Sort for natural ordering#1075
Open
tsinglua wants to merge 1 commit intocosmos:mainfrom
Open
refactor: replace sort.Slice with slices.Sort for natural ordering#1075tsinglua wants to merge 1 commit intocosmos:mainfrom
tsinglua wants to merge 1 commit intocosmos:mainfrom
Conversation
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
+ Coverage 65.45% 65.48% +0.03%
==========================================
Files 331 331
Lines 23262 23258 -4
==========================================
+ Hits 15225 15231 +6
+ Misses 6894 6884 -10
Partials 1143 1143
🚀 New features to boost your workflow:
|
Contributor
|
are there tests that validate thiss? |
Signed-off-by: tsinglua <tsinglua@outlook.com>
Author
@aljo242 The corresponding test cases have been added. Please review again. |
Author
yihuang
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
The new signed pr for #1068
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch